From e1ef6860efc0ce58d919cbbfa11b8c2408a80702 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjamin=20H=C3=A4ttasch?=
<benjamin.haettasch@fachschaft.informatik.tu-darmstadt.de>
Date: Mon, 2 Jan 2023 20:29:09 +0100
Subject: [PATCH] Add further view tests for admin interface and fix access
control issues detected by this
---
AKModel/admin.py | 8 ++++----
AKModel/tests.py | 11 ++++++++++-
AKModel/urls.py | 2 +-
3 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/AKModel/admin.py b/AKModel/admin.py
index caa7eed7..a6aae5ae 100644
--- a/AKModel/admin.py
+++ b/AKModel/admin.py
@@ -53,10 +53,10 @@ class EventAdmin(admin.ModelAdmin):
from AKScheduling.urls import get_admin_urls_scheduling
urls.extend(get_admin_urls_scheduling(self.admin_site))
urls.extend([
- path('plan/publish/', PlanPublishView.as_view(), name="plan-publish"),
- path('plan/unpublish/', PlanUnpublishView.as_view(), name="plan-unpublish"),
- path('<slug:event_slug>/defaultSlots/', DefaultSlotEditorView.as_view(), name="default-slots-editor"),
- path('<slug:event_slug>/importRooms/', RoomBatchCreationView.as_view(), name="room-import"),
+ path('plan/publish/', self.admin_site.admin_view(PlanPublishView.as_view()), name="plan-publish"),
+ path('plan/unpublish/', self.admin_site.admin_view(PlanUnpublishView.as_view()), name="plan-unpublish"),
+ path('<slug:event_slug>/defaultSlots/', self.admin_site.admin_view(DefaultSlotEditorView.as_view()), name="default-slots-editor"),
+ path('<slug:event_slug>/importRooms/', self.admin_site.admin_view(RoomBatchCreationView.as_view()), name="room-import"),
])
urls.extend(super().get_urls())
return urls
diff --git a/AKModel/tests.py b/AKModel/tests.py
index 5fb99ca6..99772180 100644
--- a/AKModel/tests.py
+++ b/AKModel/tests.py
@@ -99,7 +99,16 @@ class ModelViewTests(BasicViewTests, TestCase):
]
VIEWS_STAFF_ONLY = [
- ('admin:index', {})
+ ('admin:index', {}),
+ ('admin:event_status', {'slug': 'kif42'}),
+ ('admin:event_requirement_overview', {'event_slug': 'kif42'}),
+ ('admin:ak_csv_export', {'event_slug': 'kif42'}),
+ ('admin:ak_wiki_export', {'slug': 'kif42'}),
+ ('admin:ak_delete_orga_messages', {'event_slug': 'kif42'}),
+ ('admin:ak_slide_export', {'event_slug': 'kif42'}),
+ ('admin:default-slots-editor', {'event_slug': 'kif42'}),
+ ('admin:room-import', {'event_slug': 'kif42'}),
+ ('admin:new_event_wizard_start', {}),
]
def test_admin(self):
diff --git a/AKModel/urls.py b/AKModel/urls.py
index cee15bb0..8113ee1b 100644
--- a/AKModel/urls.py
+++ b/AKModel/urls.py
@@ -83,5 +83,5 @@ def get_admin_urls_event(admin_site):
name="ak_wiki_export"),
path('<slug:event_slug>/delete-orga-messages/', admin_site.admin_view(AKMessageDeleteView.as_view()),
name="ak_delete_orga_messages"),
- path('<slug:event_slug>/ak-slide-export/', ExportSlidesView.as_view(), name="ak_slide_export"),
+ path('<slug:event_slug>/ak-slide-export/', admin_site.admin_view(ExportSlidesView.as_view()), name="ak_slide_export"),
]
--
GitLab