From 2b0ee263548f8bb0c455519b673164640dc603a7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjamin=20H=C3=A4ttasch?=
<benjamin.haettasch@fachschaft.informatik.tu-darmstadt.de>
Date: Wed, 16 Aug 2023 16:13:28 +0200
Subject: [PATCH] Improve AKPlan
Add or complete docstrings
Remove code smells (unused variables)
---
AKPlan/tests.py | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/AKPlan/tests.py b/AKPlan/tests.py
index e19157c0..69365c2b 100644
--- a/AKPlan/tests.py
+++ b/AKPlan/tests.py
@@ -4,6 +4,9 @@ from AKModel.tests import BasicViewTests
class PlanViewTests(BasicViewTests, TestCase):
+ """
+ Tests for AKPlan
+ """
fixtures = ['model.json']
APP_NAME = 'plan'
@@ -15,7 +18,10 @@ class PlanViewTests(BasicViewTests, TestCase):
]
def test_plan_hidden(self):
- view_name_with_prefix, url = self._name_and_url(('plan_overview', {'event_slug': 'kif23'}))
+ """
+ Test correct handling of plan visibility
+ """
+ _, url = self._name_and_url(('plan_overview', {'event_slug': 'kif23'}))
self.client.logout()
response = self.client.get(url)
@@ -28,8 +34,11 @@ class PlanViewTests(BasicViewTests, TestCase):
msg_prefix="Plan is not visible for staff user")
def test_wall_redirect(self):
- view_name_with_prefix, url_wall = self._name_and_url(('plan_wall', {'event_slug': 'kif23'}))
- view_name_with_prefix, url_plan = self._name_and_url(('plan_overview', {'event_slug': 'kif23'}))
+ """
+ Test: Make sure that user is redirected from wall to overview when plan is hidden
+ """
+ _, url_wall = self._name_and_url(('plan_wall', {'event_slug': 'kif23'}))
+ _, url_plan = self._name_and_url(('plan_overview', {'event_slug': 'kif23'}))
response = self.client.get(url_wall)
self.assertRedirects(response, url_plan,
--
GitLab