Skip to content
Snippets Groups Projects

Feature: Add export discretization length for JSON-export

Merged Felix Blanke requested to merge feature/add-duration-length into main
All threads resolved!

Addresses and closes #17 (closed).

Merge request reports

Pipeline #271321 passed

Pipeline passed for ed98da8d on feature/add-duration-length

Test coverage 86.00% (0.00%) from 1 job
Approved by

Merged by Lorenzo ContiLorenzo Conti 2 months ago (Feb 6, 2025 6:17pm UTC)

Merge details

  • Changes merged into main with fe24cd4e.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #271322 passed

Pipeline passed for fe24cd4e on main

Test coverage 86.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • The documentation and implementation of this feature do not fit. One is the reciprocal of the other. I think the version in the documentation is more intuitive and we should change the implementation to be consistent.

  • Lorenzo Conti requested changes

    requested changes

  • Lorenzo Conti resolved all threads

    resolved all threads

  • Lorenzo Conti added 1 commit

    added 1 commit

    • ed98da8d - Apply 3 suggestion(s) to 2 file(s)

    Compare with previous version

  • Lorenzo Conti approved this merge request

    approved this merge request

  • Lorenzo Conti enabled an automatic merge when all merge checks for ed98da8d pass

    enabled an automatic merge when all merge checks for ed98da8d pass

  • Lorenzo Conti mentioned in commit fe24cd4e

    mentioned in commit fe24cd4e

  • Please register or sign in to reply
    Loading