Merge branch 'linting' into 'master'

Add ansible-lint and fix all warnings and errors

See merge request !2

.gitlab-ci.yml

 ---
 stages:
   - linting
-# Change pip's cache directory to be inside the project directory since we can
-# only cache local items.
-variables:
-  PIP_CACHE_DIR: "$CI_PROJECT_DIR/.cache/pip"
+
 cache:
   paths:
     - .cache
+
 ansible-lint:
   stage: linting
-  image: registry.gitlab.com/pipeline-components/ansible-lint:latest
-  before_script:
-    - pip3 install yamllint
+  image:
+    name: registry.gitlab.fachschaften.org/fsi-ansible/ci-docker-image:latest
+    entrypoint: [""]
   script:
-    - ansible-lint .
+    - ansible-lint -v --offline

meta/main.yml

@@ -3,7 +3,7 @@ galaxy_info:
   author: Fachschaft Informatik, TU Dortmund
   description: Install and configure a netdata collector
   license: MIT
-  min_ansible_version: 2.9
+  min_ansible_version: "2.9"
   platforms:
     - name: Ubuntu
       versions:

tasks/main.yml

 ---
 - name: Copy netdata config
-  template:
+  ansible.builtin.template:
     src: netdata.conf.j2
     dest: /etc/netdata/netdata.conf
     owner: root
@@ -9,7 +9,7 @@
   notify: restart netdata
 
 - name: Copy netdata stream config
-  template:
+  ansible.builtin.template:
     src: stream.conf.j2
     dest: /etc/netdata/stream.conf
     owner: root
@@ -18,7 +18,7 @@
   notify: restart netdata
 
 - name: Copy netdata python.d config
-  template:
+  ansible.builtin.template:
     src: python.d.conf.j2
     dest: /etc/netdata/python.d.conf
     owner: root
@@ -27,7 +27,7 @@
   notify: restart netdata
 
 - name: Copy netdata mysql.plugin config
-  template:
+  ansible.builtin.template:
     src: mysql.conf.j2
     dest: /etc/netdata/python.d/mysql.conf
     owner: root
@@ -37,7 +37,7 @@
   notify: restart netdata
 
 - name: Copy netdata haproxy.plugin config
-  template:
+  ansible.builtin.template:
     src: haproxy.conf.j2
     dest: /etc/netdata/python.d/haproxy.conf
     owner: root
@@ -47,6 +47,6 @@
   notify: restart netdata
 
 - name: Enable netdata
-  service:
+  ansible.builtin.service:
     name: netdata
     enabled: true