Skip to content
Snippets Groups Projects
Commit f9bf07a5 authored by Felix Schäfer's avatar Felix Schäfer :construction_worker:
Browse files

Remove nonces, state is enough

parent ccceb397
No related branches found
No related tags found
No related merge requests found
...@@ -59,10 +59,8 @@ class OIDCAuthBackend(BaseAuthBackend): ...@@ -59,10 +59,8 @@ class OIDCAuthBackend(BaseAuthBackend):
def authentication_url(self, request): def authentication_url(self, request):
oidc_state = rndstr() oidc_state = rndstr()
oidc_nonce = rndstr()
request.session["oidc_state"] = { request.session["oidc_state"] = {
oidc_state: { oidc_state: {
"nonce": oidc_nonce,
"next": request.GET.get("next", None), "next": request.GET.get("next", None),
"generated_on": int(time.time()), "generated_on": int(time.time()),
} }
...@@ -73,7 +71,6 @@ class OIDCAuthBackend(BaseAuthBackend): ...@@ -73,7 +71,6 @@ class OIDCAuthBackend(BaseAuthBackend):
"client_id": self.client.client_id, "client_id": self.client.client_id,
"response_type": "code", "response_type": "code",
"scope": self.scopes, "scope": self.scopes,
"nonce": oidc_nonce,
"redirect_uri": self.redirect_uri(request), "redirect_uri": self.redirect_uri(request),
"state": oidc_state, "state": oidc_state,
} }
...@@ -104,9 +101,6 @@ class OIDCAuthBackend(BaseAuthBackend): ...@@ -104,9 +101,6 @@ class OIDCAuthBackend(BaseAuthBackend):
if response_state not in oidc_state: if response_state not in oidc_state:
return [None, None] return [None, None]
if auth_response["nonce"] != oidc_state[response_state]["nonce"]:
return [None, None]
if oidc_state[response_state]["generated_on"] < time.time() + 5 * 60: if oidc_state[response_state]["generated_on"] < time.time() + 5 * 60:
return [None, None] return [None, None]
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment