fix oidc

docker-compose.yml

@@ -66,7 +66,7 @@ services:
             - "SHARELATEX_ALLOW_ANONYMOUS_READ_AND_WRITE_SHARING=true"
             - "SHARELATEX_ALLOW_PUBLIC_ACCESS=true"
  
-            - "SHARELATEX_LEFT_FOOTER=[{\"text\": \"Powered by Overleaf and pimped up for the Ruhr valley\"}]"
+            - "SHARELATEX_LEFT_FOOTER=[{\"text\": \"Pimped up for the Ruhr valley\"}]"
             # SHARELATEX_RIGHT_FOOTER: '[{"text": "Hello I am on the Right"} ]'
 
             # SHARELATEX_EMAIL_FROM_ADDRESS: "team@sharelatex.com"

services/web/app/src/Features/Authentication/AuthenticationController.js

@@ -575,14 +575,14 @@ const AuthenticationController = {
           UserCreator.createNewUser({
             holdingAccount: false,
             email: profile.emails[0].value,
-            first_name: profile.name[process.env.OIDC_FIRST_NAME ?? "givenName"],
-            last_name: profile.name[process.env.OIDC_LAST_NAME ?? "familyName"]
+            first_name:!process.env.OIDC_FIRST_NAME  ? profile.name.givenName : profile[process.env.OIDC_FIRST_NAME ?? "givenName"],
+            last_name: !process.env.OIDC_LAST_NAME  ? profile.name.familyName : profile[process.env.OIDC_LAST_NAME ?? "familyName"]
           }, function (user) {
             return callback(null, user);
           })
         } else {
-          user.first_name = profile.name[process.env.OIDC_FIRST_NAME ?? "givenName"],
-          user.last_name = profile.name[process.env.OIDC_LAST_NAME ?? "familyName"]
+          user.first_name = !process.env.OIDC_FIRST_NAME  ? profile.name.givenName : profile[process.env.OIDC_FIRST_NAME ?? "givenName"],
+          user.last_name = !process.env.OIDC_LAST_NAME  ? profile.name.familyName : profile[process.env.OIDC_LAST_NAME ?? "familyName"] 
           user.save(function (error) {
             if (error) {
               return callback(error);