Revert "Refactor to build suffixes list at init time" #1

This reverts commit 5521d789.

src/main/java/org/fachschaften/keycloak/form_extensions/SignupFormAction.java

@@ -33,21 +33,62 @@ public class SignupFormAction implements FormAction, FormActionFactory {
     private static Requirement[] REQUIREMENT_CHOICES = { Requirement.REQUIRED, Requirement.DISABLED };
 
     private static String[] unimailDomains = {
-        "rwth-aachen.de", "fsmpi.eu",
-        "uni-bremen.de", "tzi.de", "tzi.org", "stugen.de", "fbmi.de",
-        "d120.de", "tu-darmstadt.de",
-        "tu-dortmund.de", "uni-dortmund.de", "udo.edu", "oh14.de", "fachschaften.org",
-        "ifsr.de",
-        "uni-due.de",
-        "thm.de", "th-mittelhessen.de", "fh-giessen-friedberg.de", "fh-giessen.de",
-        "thm.de", "th-mittelhessen.de", "fh-giessen-friedberg.de", "fh-friedberg.de",
-        "thm.de", "th-mittelhessen.de", "fh-giessen-friedberg.de", "fh-friedberg.de",
-        "hs-karlsruhe.de",
-        "lmu.de", "uni-muenchen.de",
-        "uni-paderborn.de", "upb.de",
-    };
+        // exact domains
+        "@rwth-aachen.de",
+        "@fsmpi.eu",
+        "@uni-bremen.de",
+        "@tzi.de",
+        "@tzi.org",
+        "@stugen.de",
+        "@fbmi.de",
+        "@d120.de",
+        "@tu-darmstadt.de",
+        "@tu-dortmund.de",
+        "@uni-dortmund.de",
+        "@udo.edu",
+        "@oh14.de",
+        "@fachschaften.org",
+        "@ifsr.de",
+        "@uni-due.de",
+        "@thm.de",
+        "@th-mittelhessen.de",
+        "@fh-giessen-friedberg.de",
+        "@fh-giessen.de",
+        "@fh-friedberg.de",
+        "@hs-karlsruhe.de",
+        "@lmu.de",
+        "@uni-muenchen.de",
+        "@uni-paderborn.de",
+        "@upb.de",
+        // subdomains
+        ".rwth-aachen.de",
+        ".fsmpi.eu",
+        ".uni-bremen.de",
+        ".tzi.de",
+        ".tzi.org",
+        ".stugen.de",
+        ".fbmi.de",
+        ".d120.de",
+        ".tu-darmstadt.de",
+        ".tu-dortmund.de",
+        ".uni-dortmund.de",
+        ".udo.edu",
+        ".oh14.de",
+        ".fachschaften.org",
+        ".ifsr.de",
+        ".uni-due.de",
+        ".thm.de",
+        ".th-mittelhessen.de",
+        ".fh-giessen-friedberg.de",
+        ".fh-giessen.de",
+        ".fh-friedberg.de",
+        ".hs-karlsruhe.de",
+        ".lmu.de",
+        ".uni-muenchen.de",
+        ".uni-paderborn.de",
+        ".upb.de",
 
-    private String[] unimailDomainsSuffixes;
+    };
 
     @Override
     public void close() {
@@ -65,12 +106,6 @@ public class SignupFormAction implements FormAction, FormActionFactory {
 
     @Override
     public void init(Scope arg0) {
-        unimailDomainsSuffixes = Stream.concat(
-            // suffixes for subdomains
-            Arrays.stream(unimailDomains).distinct().map(d -> "." + d),
-            // suffixes for exact domains
-            Arrays.stream(unimailDomains).distinct().map(d -> "@" + d)
-        ).toArray(String[]::new);
     }
 
     @Override
@@ -143,9 +178,9 @@ public class SignupFormAction implements FormAction, FormActionFactory {
 
         String email = formData.getFirst(Validation.FIELD_EMAIL);
 
-        Stream<String> unimailDomainsSuffixesStream = Arrays.stream(unimailDomainsSuffixes);
+        Stream<String> unimailDomainsStream = Arrays.stream(unimailDomains);
 
-        if (!unimailDomainsSuffixesStream.anyMatch( f -> email.endsWith(f) )) {
+        if (!unimailDomainsStream.anyMatch( f -> email.endsWith(f) )) {
             errors.add(new FormMessage(Validation.FIELD_EMAIL, "notInUnimailDomainsMessage"));
         }